Add routing rules for WAF logs based on log format#7836
Merged
kaiyan-sheng merged 5 commits intoelastic:mainfrom Sep 21, 2023
Merged
Add routing rules for WAF logs based on log format#7836kaiyan-sheng merged 5 commits intoelastic:mainfrom
kaiyan-sheng merged 5 commits intoelastic:mainfrom
Conversation
tommyers-elastic
approved these changes
Sep 18, 2023
🌐 Coverage report
|
|
Package awsfirehose - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=awsfirehose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to enhance routing rules for WAF logs based its log format instead of firehose stream name and cloudwatch log group name. This way when WAF logs are sent to S3 bucket -> lambda -> firehose, our
awsfirehoseintegration will still be able to route it correctly.This PR also removes all(will make this a separate change, this is causing error when runningnamespacein routing rules since we are using the default, no need to specify it.elastic-package test -v --report-format xUnit --report-output file --test-coveragecommand)Checklist
changelog.ymlfile.