Skip to content

[azure_application_insights] [app_insights] Add dimensions and metric_type for metrics#7610

Merged
gpop63 merged 6 commits intoelastic:mainfrom
gpop63:azure_app-insights_dimensions
Sep 19, 2023
Merged

[azure_application_insights] [app_insights] Add dimensions and metric_type for metrics#7610
gpop63 merged 6 commits intoelastic:mainfrom
gpop63:azure_app-insights_dimensions

Conversation

@gpop63
Copy link
Copy Markdown
Contributor

@gpop63 gpop63 commented Aug 30, 2023 •
edited
Loading

What does this PR do?

Dimensions added:

  • agent.id
  • azure.dimensions.*
  • azure.namespace
  • cloud.region
  • azure.resource.id
  • azure.timegrain
  • azure.dimensions.fingerprint

Added an ingest pipeline to create a fingerprint of the azure.dimensions field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 self-assigned this Aug 30, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-19T10:56:32.421+0000

  • Duration: 15 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 30, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.574
Classes 100.0% (0/0) 💚 2.574
Methods 57.143% (4/7) 👎 -35.439
Lines 100.0% (0/0) 💚 11.163
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review August 30, 2023 12:03
@gpop63 gpop63 requested a review from a team as a code owner August 30, 2023 12:03
@gpop63 gpop63 mentioned this pull request Aug 30, 2023
Closed
10 tasks
tetianakravchenko
tetianakravchenko reviewed Sep 1, 2023
View reviewed changes
packages/azure_application_insights/data_stream/app_insights/fields/package-fields.yml
dimension: true
description: |
Autogenerated ID representing the fingerprint of the azure.dimensions object
- name: metrics.*.*
Copy link
Copy Markdown
Contributor

@tetianakravchenko tetianakravchenko Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where metrics are actually stored? in this field or in azure.app_insights.metrics.*.* ? I think one of them is redundant and should be removed

Copy link
Copy Markdown
Contributor

@zmoog zmoog Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to some app insights metrics I collected in June, the app insight metricset stores metrics in the azure.metrics.* fields:

image

Copy link
Copy Markdown
Contributor

@zmoog zmoog Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpop63, did you get metrics in these fields as well in your recent tests?

Copy link
Copy Markdown
Contributor Author

@gpop63 gpop63 Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmoog Yeah, the metrics are stored in azure.metrics so the metrics from fields.yml could be removed.

Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like metrics collected from azure.monitor also store fields under azure.metrics. Will that be a problem?

Copy link
Copy Markdown
Contributor

@zmoog zmoog Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, this should be okay. All metrics in the azure.monitor field seem fine.

zmoog
zmoog requested changes Sep 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should double-check in which fields the metricset is storing metrics.

@gpop63 gpop63 mentioned this pull request Sep 7, 2023
Closed
31 tasks
tetianakravchenko
tetianakravchenko approved these changes Sep 11, 2023
View reviewed changes
packages/azure_application_insights/changelog.yml Outdated
@@ -1,3 +1,8 @@
- version: "1.2.0"
Copy link
Copy Markdown
Contributor

@tetianakravchenko tetianakravchenko Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to 1.1.0 if merged before #7550

@gpop63 gpop63 merged commit d3c73ec into elastic:main Sep 19, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 19, 2023

Package azure_application_insights - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=azure_application_insights

@andrewkroh andrewkroh added the Integration:azure_application_insights Azure Application Insights Metrics Overview label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng left review comments

@tetianakravchenko tetianakravchenko tetianakravchenko approved these changes

Assignees

@gpop63 gpop63

Labels

Integration:azure_application_insights Azure Application Insights Metrics Overview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gpop63 @elasticmachine @zmoog @kaiyan-sheng @tetianakravchenko @andrewkroh