-
Notifications
You must be signed in to change notification settings - Fork 608
[azure_application_insights] [app_state] Add dimensions, metric_type to the app_state data stream #7550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure_application_insights] [app_state] Add dimensions, metric_type to the app_state data stream #7550
Changes from 11 commits
080c2ab
837a33f
c3bad76
2524c67
987dd5e
9c39d88
3bc84e7
28dbde4
e31ee54
53b3ad2
6c68274
8d2d658
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,3 +15,6 @@ | |
| external: ecs | ||
| - name: host | ||
| external: ecs | ||
| - name: agent.id | ||
| external: ecs | ||
| dimension: true | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |||||||||||||||||||
| fields: | ||||||||||||||||||||
| - name: timegrain | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: > | ||||||||||||||||||||
| The Azure metric timegrain | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
@@ -25,6 +26,7 @@ | |||||||||||||||||||
|
|
||||||||||||||||||||
| - name: id | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: > | ||||||||||||||||||||
| The id of the resource | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
@@ -40,6 +42,7 @@ | |||||||||||||||||||
|
|
||||||||||||||||||||
| - name: namespace | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: > | ||||||||||||||||||||
| The namespace selected | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
@@ -54,14 +57,33 @@ | |||||||||||||||||||
| The application ID | ||||||||||||||||||||
|
|
||||||||||||||||||||
| - name: dimensions | ||||||||||||||||||||
| type: flattened | ||||||||||||||||||||
| description: > | ||||||||||||||||||||
| Azure metric dimensions. | ||||||||||||||||||||
|
|
||||||||||||||||||||
| - name: metrics.*.* | ||||||||||||||||||||
| type: object | ||||||||||||||||||||
| object_type: float | ||||||||||||||||||||
| object_type_mapping_type: "*" | ||||||||||||||||||||
| description: > | ||||||||||||||||||||
| Metrics returned. | ||||||||||||||||||||
|
|
||||||||||||||||||||
| type: group | ||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the purpose behind converting Alternate options that can be tried can be found here.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Somehow I think it could be a backporting mistake that this was changed to maybe worth to double-check with codeowners
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, not sure why
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can this be considered as a breaking change?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This may not be an isolated mistake but an intentional change. I see a similar change in mapping the
I agree with @agithomas that we must double-check whether this is a breaking change. Switching field types should not create mapping exceptions since the mapping will only change at rollover, however the search behavior may vary due to the different mapping types.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Discussed about this on slack with @gpop63. TLDR; In principle this change looks safe to me, if we are completely sure that this is the list of fields we can have here. In principle this won't be a breaking change, because
The
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But regarding the breaking change, even if it doesn't seem to be actually breaking, please try to do an upgrade from the previous mapping to the proposed here in any case 🙂
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jsoriano tested upgrading and everything is fine, no errors thrown.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jsorianom, thank you for chiming in and sharing more details and backstory! @agithomas, after these clarifications, I see no reason to dig more. In addition, @gpop63 tested the mapping transition is smooth.
I am working on adding subobjects to package-spec, so we'll have this option soon. |
||||||||||||||||||||
| fields: | ||||||||||||||||||||
| - name: cloud_role_instance | ||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. where are those fields I assume that the list defined in beats could need some updates as well
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. used for app_state configuration - https://github.com/elastic/beats/blob/main/x-pack/metricbeat/module/azure/app_state/manifest.yml |
||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: The unique identifier of the cloud instance where the application is running. | ||||||||||||||||||||
| - name: cloud_role_name | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: The name of the role that the cloud instance is performing. | ||||||||||||||||||||
| - name: exception_type | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: The type of exception that was thrown. | ||||||||||||||||||||
| - name: browser_timing_url_host | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: The host part of the URL that the browser was accessing when timings were captured. | ||||||||||||||||||||
| - name: browser_timing_url_path | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: The path part of the URL that the browser was accessing when timings were captured. | ||||||||||||||||||||
| - name: request_url_host | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: The host part of the URL that was requested. | ||||||||||||||||||||
| - name: request_name | ||||||||||||||||||||
| type: keyword | ||||||||||||||||||||
| dimension: true | ||||||||||||||||||||
| description: The name of the request that was made. | ||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this field actually present in the document?
If yes - could you please update sample_event -
integrations/packages/azure_application_insights/data_stream/app_state/sample_event.json
Lines 15 to 17 in 987dd5e