Skip to content

Bump up the stack to 7.13 #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtojek merged 9 commits into from
Feb 25, 2021
Merged

Bump up the stack to 7.13 #745

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
56e1100
bump-up-stack-7.13
Feb 25, 2021
107f797
Fix: add missing Kubernetes metrics
Feb 25, 2021
e28d28a
Update version
Feb 25, 2021
712ebd9
Fix: use keyword
Feb 25, 2021
5522f9b
Update packages/kubernetes/data_stream/state_node/fields/fields.yml
mtojek Feb 25, 2021
bdf4195
Update packages/kubernetes/data_stream/state_node/fields/fields.yml
mtojek Feb 25, 2021
b62fe5a
Update packages/kubernetes/data_stream/state_node/fields/fields.yml
mtojek Feb 25, 2021
4b056cd
Fix: elastic-package build
Feb 25, 2021
c2dbf31
Add kubernetes.node.status.out_of_disk
Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.12

require (
github.com/blang/semver v3.5.1+incompatible
github.com/elastic/elastic-package v0.0.0-20210224151129-fb7942fe4b4c
github.com/elastic/elastic-package v0.0.0-20210225101737-c8b00a93596e
github.com/elastic/package-registry v0.17.0
github.com/magefile/mage v1.11.0
github.com/pkg/errors v0.9.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZmtrrCbhqsmaPHjLKYnJCaQ=
github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8PWV+bWy6jNmig1y/TA+kYO4g3RSRF0IAv0no=
github.com/elastic/elastic-package v0.0.0-20210224151129-fb7942fe4b4c h1:bxiDMfAi1Yx3IbIXPgKm69i3Ps8QKopaF3Xh6X9/gpg=
github.com/elastic/elastic-package v0.0.0-20210224151129-fb7942fe4b4c/go.mod h1:hzJTWwSTpP3mLK9NcjnoLifXmOjitGbVwgI/RPmsEGE=
github.com/elastic/elastic-package v0.0.0-20210225101737-c8b00a93596e h1:robuyReHsYgD3qlg9Z7Ro7Xqbzm0XqS03V/XKkuriOg=
github.com/elastic/elastic-package v0.0.0-20210225101737-c8b00a93596e/go.mod h1:hzJTWwSTpP3mLK9NcjnoLifXmOjitGbVwgI/RPmsEGE=
github.com/elastic/go-elasticsearch/v7 v7.9.0 h1:UEau+a1MiiE/F+UrDj60kqIHFWdzU1M2y/YtBU2NC2M=
github.com/elastic/go-elasticsearch/v7 v7.9.0/go.mod h1:OJ4wdbtDNk5g503kvlHLyErCgQwwzmDtaFC4XyOxXA4=
github.com/elastic/go-licenser v0.3.1/go.mod h1:D8eNQk70FOCVBl3smCGQt/lv7meBeQno2eI1S5apiHQ=
Expand Down
5 changes: 5 additions & 0 deletions packages/kubernetes/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.4.1"
changes:
- description: Add missing fields
type: enhancement # can be one of: enhancement, bugfix, breaking-change
link: https://github.com/elastic/integrations/pull/745
- version: "0.1.0"
changes:
- description: initial release
Expand Down
9 changes: 9 additions & 0 deletions packages/kubernetes/data_stream/state_node/fields/fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@
type: boolean
description: |
Node unschedulable status
- name: disk_pressure
type: boolean

@ChrsMark ChrsMark Feb 25, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this I found we have an issue with the mapping. Opened a PR to fix it: elastic/beats#24241. Would you mind to adjust this one accordingly?

@mtojek mtojek Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do it right now due to type check (expecting boolean). We can do it later, unfortunately, once master starts failing. Keep in mind that we'll have to wait for the Beats and Agent's image to be built first.

@ChrsMark ChrsMark Feb 25, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right!

@mtojek mtojek Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this issue privately, seems that it should be keyword (values: true, false, unknown). I will try to adjust the PR.

description: Node DiskPressure status
Comment thread
mtojek marked this conversation as resolved.
Outdated
- name: memory_pressure
type: boolean
description: Node MemoryPressure status
Comment thread
mtojek marked this conversation as resolved.
Outdated
- name: pid_pressure
type: boolean
description: Node PIDPressure status
Comment thread
mtojek marked this conversation as resolved.
Outdated
- name: cpu
type: group
fields:
Expand Down
3 changes: 3 additions & 0 deletions packages/kubernetes/docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2759,6 +2759,9 @@ An example event for `state_node` looks as following:
| kubernetes.node.name | Kubernetes node name | keyword |
| kubernetes.node.pod.allocatable.total | Node allocatable pods | long |
| kubernetes.node.pod.capacity.total | Node pod capacity | long |
| kubernetes.node.status.disk_pressure | Node DiskPressure status | boolean |
| kubernetes.node.status.memory_pressure | Node MemoryPressure status | boolean |
| kubernetes.node.status.pid_pressure | Node PIDPressure status | boolean |
| kubernetes.node.status.ready | Node ready status (true, false or unknown) | keyword |
| kubernetes.node.status.unschedulable | Node unschedulable status | boolean |
| kubernetes.pod.name | Kubernetes pod name | keyword |
Expand Down
2 changes: 1 addition & 1 deletion packages/kubernetes/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: kubernetes
title: Kubernetes
version: 0.4.0
version: 0.4.1
license: basic
description: Kubernetes Integration
type: integration
Expand Down