Skip to content

[AWS] Disable TSDB on AWS Billing #7435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
constanca-m merged 2 commits into from
Aug 17, 2023
Merged

[AWS] Disable TSDB on AWS Billing #7435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ba63c
Disable TSDB on AWS Billing.
constanca-m Aug 17, 2023
6b8fbd9
Disable TSDB on AWS Billing.
constanca-m Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/aws/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.53.1"
changes:
- description: Disable TSDB on AWS Billing.
type: enhancement
link: https://github.com/elastic/integrations/pull/7435
- version: "1.53.0"
changes:
- description: Add AWS API Gateway custom acccess logging fields.
Expand Down
2 changes: 0 additions & 2 deletions packages/aws/data_stream/billing/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
title: AWS Billing Metrics
type: metrics
elasticsearch:
Copy link
Copy Markdown
Contributor

@tetianakravchenko tetianakravchenko Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it actually cause a rollover of the index?
what will be the index_mode of a new index (after rollover)?

Copy link
Copy Markdown
Contributor Author

@constanca-m constanca-m Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the other PR, this disables TSDB on all AWS Billing versions, so there should never exist a TSDB index for this. But, if in case it is enabled and we rollover, I am not sure if it will do the update automatically or if it is like changing look_ahead and we have to do it manually.

Copy link
Copy Markdown
Contributor

@tetianakravchenko tetianakravchenko Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if in case it is enabled and we rollover, I am not sure if it will do the update automatically or if it is like changing look_ahead and we have to do it manually.

my question is mainly for the case when tsdb is already enabled and we are trying to upgrade the package version. I think we need to test this scenario to understand how it works

Copy link
Copy Markdown
Contributor Author

@constanca-m constanca-m Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree, it is harder to test without doing the manual rollover because of the 24h.

index_mode: "time_series"
streams:
- input: aws/metrics
vars:
Expand Down
2 changes: 1 addition & 1 deletion packages/aws/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: aws
title: AWS
version: 1.53.0
version: 1.53.1
license: basic
description: Collect logs and metrics from Amazon Web Services (AWS) with Elastic Agent.
type: integration
Expand Down