Skip to content

[cisco_meraki] Address the changes in Firmware MX18.101#7391

Merged
bhapas merged 2 commits intoelastic:mainfrom
bhapas:cisco-meraki-issue-7387
Aug 16, 2023
Merged

[cisco_meraki] Address the changes in Firmware MX18.101#7391
bhapas merged 2 commits intoelastic:mainfrom
bhapas:cisco-meraki-issue-7387

Conversation

@bhapas
Copy link
Copy Markdown
Contributor

@bhapas bhapas commented Aug 15, 2023

What does this PR do?

Cisco has changed the event_type for flow/ruleset logs, from flows to multiple other types. See the info box in the "Flows" paragraph in documentation, and the list of event_types This causes the logs-cisco_meraki.log pipeline to skip the logs-cisco_meraki.log-flows pipeline.

The flows pipeline also needs updating to correctly parse the new event types.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

@bhapas bhapas added bug Something isn't working, use only for issues Team:Security-External Integrations labels Aug 15, 2023
@bhapas bhapas self-assigned this Aug 15, 2023
@bhapas bhapas force-pushed the cisco-meraki-issue-7387 branch from 6e6c3d1 to 2bc2270 Compare August 15, 2023 14:25
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-16T05:01:54.472+0000

  • Duration: 19 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 15, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚 3.453
Classes 100.0% (9/9) 💚 3.453
Methods 100.0% (65/65) 💚 8.362
Lines 98.046% (1104/1126) 👍 9.975
Conditionals 100.0% (0/0) 💚

@bhapas bhapas marked this pull request as ready for review August 15, 2023 14:49
@bhapas bhapas requested a review from a team as a code owner August 15, 2023 14:49
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@bhapas bhapas requested a review from efd6 August 16, 2023 05:02
@bhapas bhapas merged commit f5f1be2 into elastic:main Aug 16, 2023
@bhapas bhapas deleted the cisco-meraki-issue-7387 branch August 16, 2023 05:36
@elasticmachine
Copy link
Copy Markdown

Package cisco_meraki - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:cisco_meraki Cisco Meraki

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cisco-meraki integration can't parse data

4 participants