Skip to content

[Cloud Security] Update CSPM url#7383

Merged
orestisfl merged 1 commit intoelastic:mainfrom
orestisfl:aws-orgs-cf-more-permissions
Aug 15, 2023
Merged

[Cloud Security] Update CSPM url#7383
orestisfl merged 1 commit intoelastic:mainfrom
orestisfl:aws-orgs-cf-more-permissions

Conversation

@orestisfl
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds more organization-level read permissions

This will future-proof our CloudFormation template for future changes like elastic/cloudbeat#1177 and elastic/cloudbeat#1214 that will require more permissions in the organization level. After merging those, newer CloudFormation templates can trim down the required permissions again.

Related issues

@orestisfl orestisfl requested a review from oren-zohar August 14, 2023 15:16
@orestisfl orestisfl requested a review from a team as a code owner August 14, 2023 15:16
@orestisfl orestisfl self-assigned this Aug 14, 2023
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this replacing the previous change log on purpose? shouldn't this be a separate log with its own description?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to introduce a new changelog here as all AWS multi-account onboarding changes can be summarized with one changelog for the 1.5.0 release.

However, a version bump is needed to build the package.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-15T08:47:09.428+0000

  • Duration: 15 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -75.0
Lines 100.0% (0/0) 💚 6.686
Conditionals 100.0% (0/0) 💚

Adds more organization-level read permissions
@orestisfl orestisfl force-pushed the aws-orgs-cf-more-permissions branch from 31951e8 to 0d5e358 Compare August 15, 2023 08:46
@orestisfl orestisfl merged commit 29c2be3 into elastic:main Aug 15, 2023
@orestisfl orestisfl deleted the aws-orgs-cf-more-permissions branch August 15, 2023 09:02
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:cloud_security_posture Security Posture Management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants