Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memcached TSDB Enablement #6983

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

agithomas
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR enables TSDB by default for the memcached package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@agithomas agithomas marked this pull request as ready for review July 17, 2023 16:22
@agithomas agithomas requested a review from a team as a code owner July 17, 2023 16:22
@agithomas agithomas mentioned this pull request Jul 17, 2023
11 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-17T16:16:21.020+0000

  • Duration: 14 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 13.636
Classes 100.0% (0/0) 💚 13.636
Methods 75.0% (3/4) 👎 -8.333
Lines 100.0% (0/0) 💚 14.997
Conditionals 100.0% (0/0) 💚

Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas agithomas merged commit bcc8399 into elastic:main Aug 1, 2023
@elasticmachine
Copy link

Package memcached - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=memcached

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Memcached ] TSDB enablement
4 participants