[AWS] Add metric type to SNS, SQS and Billing data streams #6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Can this PR be merged after code-owner review? |
aspacca
approved these changes
Jun 5, 2023
packages/aws/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.36.9" | |||
There was a problem hiding this comment.
nit: in #6365 we bumped minor version, here only patch one
why the difference? :)
|
Package aws - 1.40.0 containing this change is available at https://epr.elastic.co/search?package=aws |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Add metric type to SNS. Signed-off-by: constanca-m <[email protected]> * Add metric type to SQS. Signed-off-by: constanca-m <[email protected]> * Add metric type to Billing. Signed-off-by: constanca-m <[email protected]> * Update changelog. Signed-off-by: constanca-m <[email protected]> * Update files. Signed-off-by: constanca-m <[email protected]> --------- Signed-off-by: constanca-m <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds metric type to SNS, SQS and Billing data streams.
Billing:
From my understanding, most metrics are estimates, so they can go up and down. The ones that are not (
UnblendedCostandUsageQuantity) consider a specific time window.SNS:
Values are only considered for a specific time window, after that they reset for the next time window. This causes lots of ups and downs over time, and since the next value received for a specific field does not take into account the previous, all of them were considered gauge. Take this field (
NumberOfMessagesPublished.sum) as an example:SQS:
Same logic was applied. Example of a gauge field that might look like a counter from the description is
messages.received. When we visualize that metric, we can see that is in fact a gauge:Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Refer to #6293.
Related issues
Relates to #6293.