windows: improve regular expression search efficiency to allow parsing large events #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
…g large events Due to recursive descent, the previous patterns resulted in significant fruitless work, surpassing the regular expression cost limit. This short-circuits the search to improve efficiency.
taylor-swanson
approved these changes
May 18, 2023
|
Package windows - 1.21.1 containing this change is available at https://epr.elastic.co/search?package=windows |
efd6
added a commit
to efd6/beats
that referenced
this pull request
Jul 31, 2023
…erformance The details regexp pattern for the powershell data stream was improved in the windows integration in elastic/integrations#6154 to reduce backtracking costs that caused regexp costs to exceed the set runtime limits. The same pattern on other data streams and in winlogbeat was not updated. This change brings winlogbeat up to date with the change.
Merged
7 tasks
efd6
added a commit
to efd6/beats
that referenced
this pull request
Jul 31, 2023
…erformance The details regexp pattern for the powershell data stream was improved in the windows integration in elastic/integrations#6154 to reduce backtracking costs that caused regexp costs to exceed the set runtime limits. The same pattern on other data streams and in winlogbeat was not updated. This change brings winlogbeat up to date with the change.
4 tasks
efd6
added a commit
to elastic/beats
that referenced
this pull request
Jul 31, 2023
…erformance (#36178) The details regexp pattern for the powershell data stream was improved in the windows integration in elastic/integrations#6154 to reduce backtracking costs that caused regexp costs to exceed the set runtime limits. The same pattern on other data streams and in winlogbeat was not updated. This change brings winlogbeat up to date with the change.
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Jul 31, 2023
…erformance (#36178) The details regexp pattern for the powershell data stream was improved in the windows integration in elastic/integrations#6154 to reduce backtracking costs that caused regexp costs to exceed the set runtime limits. The same pattern on other data streams and in winlogbeat was not updated. This change brings winlogbeat up to date with the change. (cherry picked from commit d8db41b)
efd6
pushed a commit
to elastic/beats
that referenced
this pull request
Jul 31, 2023
…etails regexp pattern performance (#36186) The details regexp pattern for the powershell data stream was improved in the windows integration in elastic/integrations#6154 to reduce backtracking costs that caused regexp costs to exceed the set runtime limits. The same pattern on other data streams and in winlogbeat was not updated. This change brings winlogbeat up to date with the change. (cherry picked from commit d8db41b)
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…erformance (elastic#36178) The details regexp pattern for the powershell data stream was improved in the windows integration in elastic/integrations#6154 to reduce backtracking costs that caused regexp costs to exceed the set runtime limits. The same pattern on other data streams and in winlogbeat was not updated. This change brings winlogbeat up to date with the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Due to recursive descent, the previous patterns resulted in significant fruitless work, surpassing the regular expression cost limit. This short-circuits the search to improve efficiency.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots