Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes][Container] Add container name as dimension #6108

Merged
merged 3 commits into from
May 5, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

The dimensions set for the container data stream are not enough, since a pod can have multiple containers. In that case, without setting the container name (unique per pod) as dimension, there would be no way to distinguish between documents from different containers in the same pod.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #4618.

Signed-off-by: constanca-m <[email protected]>
@constanca-m constanca-m requested a review from gizas May 5, 2023 14:45
@constanca-m constanca-m self-assigned this May 5, 2023
@constanca-m constanca-m requested review from a team as code owners May 5, 2023 14:45
@constanca-m constanca-m requested a review from devamanv May 5, 2023 14:45
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
@elasticmachine
Copy link

elasticmachine commented May 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-05T14:47:51.157+0000

  • Duration: 28 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 5, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 96.154% (75/78) 👎 -3.846
Lines 100.0% (0/0) 💚 1.955
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m merged commit 06214f9 into elastic:main May 5, 2023
@constanca-m constanca-m deleted the kubernetes-add-dimension branch May 5, 2023 15:36
@elasticmachine
Copy link

Package kubernetes - 1.36.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@tetianakravchenko
Copy link
Contributor

tetianakravchenko commented May 10, 2023

@constanca-m why was this field introduced? shouldn't it be covered by the container.id field, that is set as dimension already?

@gizas
Copy link
Contributor

gizas commented May 10, 2023

I had missed that @tetianakravchenko ! I thought we had only pod.uid which was not enough that is why this PR.

Indeed I think we can cancel this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants