-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kubernetes][Container] Add container name as dimension #6108
Merged
constanca-m
merged 3 commits into
elastic:main
from
constanca-m:kubernetes-add-dimension
May 5, 2023
Merged
[Kubernetes][Container] Add container name as dimension #6108
constanca-m
merged 3 commits into
elastic:main
from
constanca-m:kubernetes-add-dimension
May 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
gizas
approved these changes
May 5, 2023
🌐 Coverage report
|
Package kubernetes - 1.36.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
@constanca-m why was this field introduced? shouldn't it be covered by the |
I had missed that @tetianakravchenko ! I thought we had only pod.uid which was not enough that is why this PR. Indeed I think we can cancel this |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The dimensions set for the container data stream are not enough, since a pod can have multiple containers. In that case, without setting the container name (unique per pod) as dimension, there would be no way to distinguish between documents from different containers in the same pod.
Checklist
changelog.yml
file.Related issues
Relates to #4618.