Add ssl support to elasticsearch ingest pipeline datastream#5939
Merged
klacabane merged 6 commits intoelastic:mainfrom Apr 25, 2023
JulienOrain:patch-1
Merged
Add ssl support to elasticsearch ingest pipeline datastream#5939klacabane merged 6 commits intoelastic:mainfrom JulienOrain:patch-1
klacabane merged 6 commits intoelastic:mainfrom
JulienOrain:patch-1
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
klacabane
reviewed
Apr 24, 2023
Contributor
There was a problem hiding this comment.
Hi @JulienOrain, thank you for the change! I see that other parameters added in #5353 are also missing from the ingest_pipeline data stream. I've made a suggestion to include them.
We also need to bump the version in the manifest.yml
packages/elasticsearch/data_stream/ingest_pipeline/agent/stream/stream.yml.hbs
Show resolved
Hide resolved
Contributor
|
/test |
…m/stream.yml.hbs Co-authored-by: Kevin Lacabane <klacabane@gmail.com>
Contributor
Author
|
Hi @klacabane ! |
Contributor
|
/test |
🌐 Coverage report
|
klacabane
reviewed
Apr 25, 2023
Co-authored-by: Kevin Lacabane <klacabane@gmail.com>
Contributor
|
/test |
|
Package elasticsearch - 1.6.2 containing this change is available at https://epr.elastic.co/search?package=elasticsearch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
sslsupport to elasticsearch ingest_pipeline data streamChecklist
changelog.ymlfile.Author's Checklist
NA
How to test this PR locally
NA
Related issues
Screenshots