You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current Salesforce Integration, we don’t have pagination support for login-rest and logout-rest data streams. So if in any case, we have a response body with more than 2000 records, the next page is never called and the data will not be fetched.
Solution:
You can request the next batch of records using the provided URL with your instance and session information, and repeat until all records have been retrieved. These requests use nextRecordsUrl and don’t include any parameters. The final batch of records doesn’t have a nextRecordsUrl field and return true value for field done
kush-elastic
changed the title
[Salesforce] Add pagination support for login_rest and logout_rest
[Salesforce] Add pagination support for login_rest and logout_rest data streams
Dec 19, 2022
Please complete the internal review. Send me a note once it is done
We are not able to provide approval from the Elastic account. It seems like still, some access is missing for the Elastic GitHub integration repo. Hence we are not able to approve. We have raised an IT ticket for the same.
Please complete the internal review. Send me a note once it is done
We are not able to provide approval from the Elastic account. It seems like still, some access is missing for the Elastic GitHub integration repo. Hence we are not able to approve. We have raised an IT ticket for the same.
You may consider cancelling the IT ticket created for this purpose as it is not needed at the moment . If you decide to proceed, kindly ensure atleast one of the Elastic team member performs the code review.
Please complete the internal review. Send me a note once it is done
We are not able to provide approval from the Elastic account. It seems like still, some access is missing for the Elastic GitHub integration repo. Hence we are not able to approve. We have raised an IT ticket for the same.
You may consider cancelling the IT ticket created for this purpose as it is not needed at the moment . If you decide to proceed, kindly ensure atleast one of the Elastic team member performs the code review.
Currently, only Kush has access, But when he raises the PR, others are not able to review it. So we need at least one more person who has the access to reviewers and approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the current Salesforce Integration, we don’t have pagination support for login-rest and logout-rest data streams. So if in any case, we have a response body with more than 2000 records, the next page is never called and the data will not be fetched.
Solution:
You can request the next batch of records using the provided URL with your instance and session information, and repeat until all records have been retrieved. These requests use
nextRecordsUrland don’t include any parameters. The final batch of records doesn’t have anextRecordsUrlfield and returntruevalue for fielddoneChecklist
changelog.ymlfile.Related issues
salesforcepackage foundation along withlogin_restdata stream #4261salesforcepackage foundation along withlogout_restdata stream #4323