Skip to content

[Okta] Make URL config option a required parameter#4424

Merged
efd6 merged 2 commits intoelastic:mainfrom
legoguy1000:4413-okta-required
Oct 13, 2022
Merged

[Okta] Make URL config option a required parameter#4424
efd6 merged 2 commits intoelastic:mainfrom
legoguy1000:4413-okta-required

Conversation

@legoguy1000
Copy link
Contributor

What does this PR do?

Mark URL as required parameter

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner October 8, 2022 15:03
@elasticmachine
Copy link

elasticmachine commented Oct 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-09T14:21:01.508+0000

  • Duration: 14 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

🚀 Benchmarks report

Package okta 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
system 1206.27 598.8 -607.47 (-50.36%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.963
Classes 100.0% (1/1) 💚 2.963
Methods 100.0% (17/17) 💚 10.327
Lines 86.69% (495/571) 👎 -4.785
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit ee25b56 into elastic:main Oct 13, 2022
@legoguy1000 legoguy1000 deleted the 4413-okta-required branch October 13, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Okta] url should a required field

4 participants