Skip to content

cisco_*: remove duplicate fields#4400

Merged
efd6 merged 2 commits intoelastic:mainfrom
efd6:4398-cisco
Oct 11, 2022
Merged

cisco_*: remove duplicate fields#4400
efd6 merged 2 commits intoelastic:mainfrom
efd6:4398-cisco

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Oct 6, 2022

What does this PR do?

This removes duplicate field definitions from the non-deperecated cisco packages.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

🚀 Benchmarks report

Package cisco_meraki 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 21276.6 14705.88 -6570.72 (-30.88%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T07:27:47.984+0000

  • Duration: 19 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 266
Skipped 0
Total 266

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 95.349% (41/43) 👎 -2.155
Classes 95.349% (41/43) 👎 -2.155
Methods 97.6% (366/375) 👍 7.266
Lines 88.713% (8025/9046) 👎 -2.918
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review October 6, 2022 05:18
@efd6 efd6 requested a review from a team as a code owner October 6, 2022 05:18
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • cisco_nexus.log
    • tags could be removed from base-fields.yml instead of ecs.yml

@efd6 efd6 merged commit b439658 into elastic:main Oct 11, 2022
@efd6 efd6 deleted the 4398-cisco branch February 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD Integration:cisco_ios Cisco IOS Integration:cisco_ise Cisco ISE Integration:cisco_meraki Cisco Meraki Integration:cisco_nexus Cisco Nexus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants