Skip to content

[microsoft_dhcp] Fix broken hyperlink in docs #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efd6 merged 5 commits into from
Oct 6, 2022
Merged

[microsoft_dhcp] Fix broken hyperlink in docs #4393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8ff61e
Fix broken hyperlink
nicpenning Oct 5, 2022
4611672
Update changelog.yml
nicpenning Oct 5, 2022
ea82a0c
Update README.md
nicpenning Oct 5, 2022
6713148
Update manifest.yml
nicpenning Oct 6, 2022
64d4094
Make generated markdown match
efd6 Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/microsoft_dhcp/_dev/build/docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ Ingest logs from Microsoft DHCP Server, by default logged with the filename form
Logs may also be ingested from Microsoft DHCPv6 Server, by default logged with the filename format:
`%windir%\System32\DHCP\DhcpV6SrvLog-*.log`

Relevant documentation for Microsoft DHCP can be found on [this]https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/dd183591(v=ws.10) location.
Relevant documentation for Microsoft DHCP can be found on [this](https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/dd183591(v=ws.10)) location.

{{event "log"}}

{{fields "log"}}
{{fields "log"}}
5 changes: 5 additions & 0 deletions packages/microsoft_dhcp/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.7.1"
changes:
- description: Fix a bug in documenation with hyperlink to Microsoft website
type: enhancement
link: https://github.com/elastic/integrations/pull/4393
- version: "1.7.0"
changes:
- description: Change host.domain to host.name to reflect the event data and then extract host.domain from the host.name
Expand Down
3 changes: 2 additions & 1 deletion packages/microsoft_dhcp/docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Ingest logs from Microsoft DHCP Server, by default logged with the filename form
Logs may also be ingested from Microsoft DHCPv6 Server, by default logged with the filename format:
`%windir%\System32\DHCP\DhcpV6SrvLog-*.log`

Relevant documentation for Microsoft DHCP can be found on [this]https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/dd183591(v=ws.10) location.
Relevant documentation for Microsoft DHCP can be found on [this](https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/dd183591(v=ws.10)) location.

An example event for `log` looks as following:

Expand Down Expand Up @@ -143,3 +143,4 @@ An example event for `log` looks as following:
| tags | List of keywords used to tag each event. | keyword |
| user.name | Short name or login of the user. | keyword |
| user.name.text | Multi-field of `user.name`. | match_only_text |

2 changes: 1 addition & 1 deletion packages/microsoft_dhcp/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: microsoft_dhcp
title: Microsoft DHCP
version: "1.7.0"
version: "1.7.1"
license: basic
description: Collect logs from Microsoft DHCP with Elastic Agent.
type: integration
Expand Down