carbonblack_edr,checkpoint,cisco_umbrella,gcp,zeek: remove duplicate fields and fix types#4339
Merged
efd6 merged 2 commits intoelastic:mainfrom Sep 29, 2022
Merged
Conversation
efd6
force-pushed
the
duplicated_fields_bis
branch
from
868f7c5 to
190e704
Compare
…fields and fix types
efd6
force-pushed
the
duplicated_fields_bis
branch
from
190e704 to
e2f1af8
Compare
These were necessary to allow the v2 duplication checks, but break the tests.
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
firewall |
793.65 | 485.67 | -307.98 (-38.81%) | 💔 |
Package cisco_umbrella 👍(0) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
12195.12 | 8928.57 | -3266.55 (-26.79%) | 💔 |
Package zeek 👍(27) 💚(11) 💔(5)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
connection |
22727.27 | 15873.02 | -6854.25 (-30.16%) | 💔 |
snmp |
25000 | 20000 | -5000 (-20%) | 💔 |
weird |
28571.43 | 22222.22 | -6349.21 (-22.22%) | 💔 |
x509 |
11627.91 | 8196.72 | -3431.19 (-29.51%) | 💔 |
dhcp |
21276.6 | 16393.44 | -4883.16 (-22.95%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Contributor
endorama
approved these changes
Sep 29, 2022
Contributor
endorama
left a comment
endorama
left a comment
There was a problem hiding this comment.
GCP changes looks good to me!
This was referenced Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a second tranch of fixing duplicate fields in preparation for the ECS 8.5 update.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots