Skip to content

[microsoft_dhcp] Fix incorrect log parsing for DHCP host.domain -> host.name (redo)#4311

Merged
efd6 merged 24 commits intoelastic:mainfrom
nicpenning:tests-for-dhcp-manual
Sep 27, 2022
Merged

[microsoft_dhcp] Fix incorrect log parsing for DHCP host.domain -> host.name (redo)#4311
efd6 merged 24 commits intoelastic:mainfrom
nicpenning:tests-for-dhcp-manual

Conversation

@nicpenning
Copy link
Contributor

These are the tests and doc updates manually added.

Replaces the original PR that was botched due to CLA/credential mishap.
(#4280)

Closes #4279

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-27T01:49:12.297+0000

  • Duration: 15 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Sep 27, 2022

/test

@elasticmachine
Copy link

🚀 Benchmarks report

Package microsoft_dhcp 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 30303.03 22222.22 -8080.81 (-26.67%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 2.582
Classes 100.0% (3/3) 💚 2.582
Methods 100.0% (21/21) 💚 10.061
Lines 99.205% (624/629) 👍 7.84
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your patience with this.

@efd6 efd6 merged commit 4cfcaf2 into elastic:main Sep 27, 2022
@nicpenning
Copy link
Contributor Author

Awesome 👌🏻 And thank you for your patience putting up with me. I learned a lot and look forward contributing again in a much smoother manner.

Any idea on how long before this gets packaged up for use in Kibana?

@efd6
Copy link
Contributor

efd6 commented Sep 27, 2022

It should be promoted probably next week.

@nicpenning
Copy link
Contributor Author

Thank you.

1 similar comment
@nicpenning
Copy link
Contributor Author

Thank you.

@nicpenning
Copy link
Contributor Author

nicpenning commented Oct 2, 2022

I noticed that this is available for upgrade in the platform, however, the docs here (https://docs.elastic.co/en/integrations/microsoft_dhcp#changelog) are still not up to date. Will those come at a later time or did I miss something in the PR?

@nicpenning nicpenning deleted the tests-for-dhcp-manual branch October 4, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[microsoft_dhcp] Change host.domain to host.name to better align with ECS

3 participants