[microsoft_dhcp] Fix incorrect log parsing for DHCP host.domain -> host.name (redo)#4311
Merged
efd6 merged 24 commits intoelastic:mainfrom Sep 27, 2022
nicpenning:tests-for-dhcp-manual
Merged
[microsoft_dhcp] Fix incorrect log parsing for DHCP host.domain -> host.name (redo)#4311efd6 merged 24 commits intoelastic:mainfrom nicpenning:tests-for-dhcp-manual
efd6 merged 24 commits intoelastic:mainfrom
nicpenning:tests-for-dhcp-manual
Conversation
Fix improper field name
4 tasks
Contributor
|
/test |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
30303.03 | 22222.22 | -8080.81 (-26.67%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
efd6
approved these changes
Sep 27, 2022
Contributor
efd6
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your patience with this.
Contributor
Author
|
Awesome 👌🏻 And thank you for your patience putting up with me. I learned a lot and look forward contributing again in a much smoother manner. Any idea on how long before this gets packaged up for use in Kibana? |
Contributor
|
It should be promoted probably next week. |
Contributor
Author
|
Thank you. |
1 similar comment
Contributor
Author
|
Thank you. |
Contributor
Author
|
I noticed that this is available for upgrade in the platform, however, the docs here (https://docs.elastic.co/en/integrations/microsoft_dhcp#changelog) are still not up to date. Will those come at a later time or did I miss something in the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the tests and doc updates manually added.
Replaces the original PR that was botched due to CLA/credential mishap.
(#4280)
Closes #4279