Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for Cisco Meraki #428

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Dec 2, 2020

What does this PR do?

Add system test for Cisco Meraki.

The tests identified two issues:

  • Define ecs.version in fields.
  • Change input type from file to logfile.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Related issues

@andrewkroh andrewkroh added the enhancement New feature or request label Dec 2, 2020
@elasticmachine
Copy link

elasticmachine commented Dec 2, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2020-12-08T22:28:46.137+0000

  • Duration: 18 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 73
Skipped 0
Total 73

Define ecs.version in fields.
Change input type from `file` to `logfile`.
@andrewkroh andrewkroh marked this pull request as ready for review December 2, 2020 13:27
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh merged commit a0aea6e into elastic:master Dec 9, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Add system test for Cisco Meraki

Define ecs.version in fields.
Change input type from `file` to `logfile`.

* Add ecs.version to nexus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants