[GCP] Move dashboard visualizations to by value#4214
Merged
endorama merged 7 commits intoelastic:mainfrom Oct 6, 2022
endorama:gcp-dashboard-by-value
Merged
[GCP] Move dashboard visualizations to by value#4214endorama merged 7 commits intoelastic:mainfrom endorama:gcp-dashboard-by-value
endorama merged 7 commits intoelastic:mainfrom
endorama:gcp-dashboard-by-value
Conversation
10 tasks
Contributor
Author
|
Changelog missing, will update once this is ready to be merged |
🌐 Coverage report
|
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Besides changelog, I think we are missing the kibana version change in manifest.yml
efd6
approved these changes
Sep 22, 2022
Contributor
efd6
left a comment
There was a problem hiding this comment.
I've checked the dashboards briefly (all appear to be OK, but I have only checked that audit, firewall and vpc flow render events correctly).
mbondyra
approved these changes
Sep 23, 2022
mbondyra
left a comment
There was a problem hiding this comment.
Approved as probably moving to lens will be a part of a different PR 👌🏼
Contributor
Author
|
Added changelog and remove compatibility with kibana 7.x, as suggested. |
🚀 Benchmarks reportTo see the full report comment with |
kaiyan-sheng
reviewed
Oct 6, 2022
As suggested in #4214
kaiyan-sheng
approved these changes
Oct 6, 2022
Contributor
Author
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
As per #3448 (and it's GCP dedicated issue #3719) we want to migrate Dashboards to use by value visualization instead of by reference.
This PR does it for GCP dashboard available in GCP package as of today.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots