cisco_{asa,ftd}: fix handling of 302020 messages#4209
Merged
efd6 merged 1 commit intoelastic:mainfrom Sep 19, 2022
Merged
Conversation
efd6
added
bug
efd6
force-pushed
the
4199-cisco_asa_ftd
branch
from
e7e4657 to
349ddc9
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
djptek
approved these changes
Sep 19, 2022
Contributor
djptek
left a comment
djptek
left a comment
There was a problem hiding this comment.
"event.action": "flow-creation" looks OK in the test results
LGTM
efd6
force-pushed
the
4199-cisco_asa_ftd
branch
from
349ddc9 to
4f9d09e
Compare
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
268.82 | 168.32 | -100.5 (-59.71%) | 💔 |
Package cisco_ftd 👍(1) 💚(0) 💔(0)
To see the full report comment with /test benchmark fullreport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the handling of message type 302020 which was being incorrectly characterised as a termination event rather than a start event.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots