Skip to content

Set default endpoint for AWS to empty string #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaiyan-sheng merged 5 commits into from
Sep 21, 2022
Merged

Set default endpoint for AWS to empty string #4207

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c62a581
Set default endpoint for AWS to empty string
Sep 13, 2022
cf76e19
add changelog
Sep 13, 2022
dfc8b75
Add default region config
Sep 14, 2022
d56b5d1
update changelog entry
Sep 14, 2022
69b78f9
Merge remote-tracking branch 'upstream/main' into default_endpoint
Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/cloudflare_logpush/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: 0.1.2
changes:
- description: Set default endpoint to empty string and add default region config
type: bugfix
link: https://github.com/elastic/integrations/pull/4207
- version: 0.1.1
changes:
- description: Fix line endings.
Expand Down
3 changes: 3 additions & 0 deletions packages/cloudflare_logpush/data_stream/audit/agent/stream/aws-s3.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ role_arn: {{role_arn}}
{{#if endpoint}}
endpoint: {{endpoint}}
{{/if}}
{{#if default_region}}
default_region: {{default_region}}
{{/if}}
{{#if fips_enabled}}
fips_enabled: {{fips_enabled}}
{{/if}}
Expand Down
3 changes: 3 additions & 0 deletions packages/cloudflare_logpush/data_stream/dns/agent/stream/aws-s3.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ role_arn: {{role_arn}}
{{#if endpoint}}
endpoint: {{endpoint}}
{{/if}}
{{#if default_region}}
default_region: {{default_region}}
{{/if}}
{{#if fips_enabled}}
fips_enabled: {{fips_enabled}}
{{/if}}
Expand Down
3 changes: 3 additions & 0 deletions packages/cloudflare_logpush/data_stream/firewall_event/agent/stream/aws-s3.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ role_arn: {{role_arn}}
{{#if endpoint}}
endpoint: {{endpoint}}
{{/if}}
{{#if default_region}}
default_region: {{default_region}}
{{/if}}
{{#if fips_enabled}}
fips_enabled: {{fips_enabled}}
{{/if}}
Expand Down
3 changes: 3 additions & 0 deletions packages/cloudflare_logpush/data_stream/http_request/agent/stream/aws-s3.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ role_arn: {{role_arn}}
{{#if endpoint}}
endpoint: {{endpoint}}
{{/if}}
{{#if default_region}}
default_region: {{default_region}}
{{/if}}
{{#if fips_enabled}}
fips_enabled: {{fips_enabled}}
{{/if}}
Expand Down
3 changes: 3 additions & 0 deletions packages/cloudflare_logpush/data_stream/nel_report/agent/stream/aws-s3.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ role_arn: {{role_arn}}
{{#if endpoint}}
endpoint: {{endpoint}}
{{/if}}
{{#if default_region}}
default_region: {{default_region}}
{{/if}}
{{#if fips_enabled}}
fips_enabled: {{fips_enabled}}
{{/if}}
Expand Down
3 changes: 3 additions & 0 deletions packages/cloudflare_logpush/data_stream/network_analytics/agent/stream/aws-s3.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ role_arn: {{role_arn}}
{{#if endpoint}}
endpoint: {{endpoint}}
{{/if}}
{{#if default_region}}
default_region: {{default_region}}
{{/if}}
{{#if fips_enabled}}
fips_enabled: {{fips_enabled}}
{{/if}}
Expand Down
3 changes: 3 additions & 0 deletions packages/cloudflare_logpush/data_stream/spectrum_event/agent/stream/aws-s3.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ role_arn: {{role_arn}}
{{#if endpoint}}
endpoint: {{endpoint}}
{{/if}}
{{#if default_region}}
default_region: {{default_region}}
{{/if}}
{{#if fips_enabled}}
fips_enabled: {{fips_enabled}}
{{/if}}
Expand Down
12 changes: 10 additions & 2 deletions packages/cloudflare_logpush/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: cloudflare_logpush
title: Cloudflare Logpush
version: 0.1.1
version: 0.1.2
license: basic
description: Collect and parse logs from Cloudflare API with Elastic Agent.
type: integration
Expand Down Expand Up @@ -151,8 +151,16 @@ policy_templates:
multi: false
required: false
show_user: false
default: amazonaws.com
default: ""
description: URL of the entry point for an AWS web service.
- name: default_region
type: text
title: Default AWS Region
multi: false
required: false
show_user: false
default: ""
description: Default region to use prior to connecting to region specific services/endpoints if no AWS region is set from environment variable, credentials or instance profile. If none of the above are set and no default region is set as well, `us-east-1` is used. A region, either from environment variable, credentials or instance profile or from this default region setting, needs to be set when using regions in non-regular AWS environments such as AWS China or US Government Isolated.
- name: fips_enabled
type: bool
title: Enable S3 FIPS
Expand Down