[zscaler_zia] Remap network.protocol/scheme to valid values for uri_parts#4045
Merged
taylor-swanson merged 3 commits intoelastic:mainfrom Aug 24, 2022
taylor-swanson:3987-uri-proto
Merged
[zscaler_zia] Remap network.protocol/scheme to valid values for uri_parts#4045taylor-swanson merged 3 commits intoelastic:mainfrom taylor-swanson:3987-uri-proto
taylor-swanson merged 3 commits intoelastic:mainfrom
taylor-swanson:3987-uri-proto
Conversation
- Add script processor to build URL for parsing. Script has parameters for valid protocols and a default protocol for a fallback. If network.protocol is valid, then it is used, otherwise the protocol (scheme) used for the URL will be the default (fallback) protocol. The original network.protocol is preserved. - Removed redundant processors - Add test cases - Rename test case files to comply with package spec - Regenerate pipeline test expected files
taylor-swanson
added
bug
Contributor
Author
|
Side note, system test files/sample events were not regenerated due to: #4044 |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
taylor-swanson
changed the title
efd6
approved these changes
Aug 23, 2022
Contributor
efd6
left a comment
efd6
left a comment
There was a problem hiding this comment.
I think it's probably worth noting in the package readme that if there is not a valid scheme then the scheme is set to https.
efd6
approved these changes
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
protocols and a default protocol for a fallback. If network.protocol is valid,
then it is used, otherwise the protocol (scheme) used for the URL will be
the default (fallback) protocol. The original network.protocol is preserved.
Checklist
changelog.ymlfile.How to test this PR locally
Related issues