Conversation
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
You seem to be overwriting all existing files in this PR, is that on purpose.
To make this PR better reviewable, perhaps first just push in all the automation and scripts as part of the PR and remove the packages itself?
After we got it in, we should also discuss if we need to adjust the directory structure a bit.
| @@ -0,0 +1,13 @@ | |||
| FROM golang:1.14.2 | |||
There was a problem hiding this comment.
@kuisathaverat Would be great to get a CI setup for this repo too, if we don't already have it.
There was a problem hiding this comment.
If this is a matter of adjusting Jenkinsfile, I can handle it in the followups.
There was a problem hiding this comment.
It is about adding this repo to JJBB, needs to happen in an other repo.
| @@ -1,19 +0,0 @@ | |||
| --- | |||
There was a problem hiding this comment.
Was this removed on purpose?
There was a problem hiding this comment.
This is an old file. Not relevant to what we'll have here.
| @@ -1,4 +0,0 @@ | |||
| # Integrations repository (ONLY EXPERIMENTAL USE) | |||
There was a problem hiding this comment.
Removed on purpose? Same for all the specs files?
There was a problem hiding this comment.
Yes. All these files contain nothing relevant. Only placeholders.
Done. |
|
@ruflin I'm ok with reviewing and pushing the current state of PR and then apply next changes in followups (testing/environment, CI, docs). |
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM
Lets have follow up PR's to add the packages, cleanup magefile etc.
| } | ||
| } | ||
|
|
||
| err = BuildRootFile() |
There was a problem hiding this comment.
This will probably not be needed anymore in here?
There was a problem hiding this comment.
Not sure yet. I want to build the package directory with gzipped artifacts and mount it in the container image with EPR. I'll come back to this.
mtojek
changed the title
* [azure_app_service] - removed dotted YAML keys from manifest The format_version in the package manifest changed from 2.8.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -v -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/azure_app_service * [citrix_adc] - removed dotted YAML keys from manifest The format_version in the package manifest changed from 2.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -v -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/citrix_adc * [redis]: migration with yq * [redis] - removed dotted YAML keys from manifest The format_version in the package manifest changed from 1.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -v -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/redis * [tomcat]: migration with yq * [tomcat] - removed dotted YAML keys from manifest The format_version in the package manifest changed from 1.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -v -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/tomcat * Add validation.yml * Fix PR number in changelog
2 participants
Issue: elastic/package-registry#414
Done:
TODO: