Skip to content

Fixes to loadbalancing_metrics datastream #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
endorama merged 5 commits into from
Aug 12, 2022
Merged

Fixes to loadbalancing_metrics datastream #3986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbb8862
fix credentials_json escaping
endorama Aug 11, 2022
cc8342a
set period default to 60s
endorama Aug 11, 2022
2c35e67
fix event.dataset
endorama Aug 11, 2022
3953f6c
update sample data
endorama Aug 11, 2022
48946b3
update docs
endorama Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/gcp/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@
- description: Add GCP Load Balancing Metricset
type: enhancement
link: https://github.com/elastic/integrations/pull/2308
- description: Fix credentials_json escaping in loadbalancing_metrics
Copy link
Contributor

@tommyers-elastic tommyers-elastic Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some strange things going on here :)

type: bugfix
link: foobar
- description: Update loadbalancing_metrics default period to 60s
type: bugfix
link: foobar
- description: Fix event.dataset for loadbalancing_metrics
type: bugfix
link: foobar
- version: "2.4.0"
changes:
- description: Update package to ECS 8.4.0
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp/data_stream/loadbalancing_metrics/agent/stream/stream.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ project_id: {{project_id}}
credentials_file_path: {{credentials_file}}
{{/if}}
{{#if credentials_json}}
credentials_json: {{credentials_json}}
credentials_json: '{{credentials_json}}'
{{/if}}
{{#if region}}
region: {{region}}
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp/data_stream/loadbalancing_metrics/fields/base-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
- name: event.dataset
type: constant_keyword
description: Event dataset
value: gcp.loadbalancing
value: gcp.loadbalancing_metrics
2 changes: 1 addition & 1 deletion packages/gcp/data_stream/loadbalancing_metrics/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ streams:
- name: period
type: text
title: Period
default: 10s
default: 60s
required: true
- name: exclude_labels
type: bool
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp/data_stream/loadbalancing_metrics/sample_event.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"availability_zone": "us-central1-a"
},
"event": {
"dataset": "gcp.loadbalancing",
"dataset": "gcp.loadbalancing_metrics",
"duration": 115000,
"module": "gcp"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp/docs/loadbalancing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ An example event for `loadbalancing` looks as following:
"availability_zone": "us-central1-a"
},
"event": {
"dataset": "gcp.loadbalancing",
"dataset": "gcp.loadbalancing_metrics",
"duration": 115000,
"module": "gcp"
},
Expand Down