[tenable_sc] Fix an indefinite pagination bug by adding explicit pagination termination conditions.#3961
Merged
andrewkroh merged 3 commits intoelastic:mainfrom Aug 16, 2022
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
andrewkroh
reviewed
Aug 15, 2022
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Contributor
|
Some RCA info with regards to the endless pagination would be really good , and was this happening only for the tenable_sc integration or was it in general ? |
Contributor
Author
|
Hey @ShourieG, |
andrewkroh
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
This PR fixes the bug related to indefinite pagination by adding explicit pagination termination conditions. In the Filebeat version, 8.2.0 pagination termination was not happening. Refer to the attached issue for more information.
Checklist
Related issues
Screenshots