Skip to content

[tenable_sc] Fix an indefinite pagination bug by adding explicit pagination termination conditions.#3961

Merged
andrewkroh merged 3 commits intoelastic:mainfrom
vinit-chauhan:tenable_sc_data_collection_fix
Aug 16, 2022
Merged

[tenable_sc] Fix an indefinite pagination bug by adding explicit pagination termination conditions.#3961
andrewkroh merged 3 commits intoelastic:mainfrom
vinit-chauhan:tenable_sc_data_collection_fix

Conversation

@vinit-chauhan
Copy link
Copy Markdown
Contributor

@vinit-chauhan vinit-chauhan commented Aug 5, 2022

Type of change

  • Bug

What does this PR do?

This PR fixes the bug related to indefinite pagination by adding explicit pagination termination conditions. In the Filebeat version, 8.2.0 pagination termination was not happening. Refer to the attached issue for more information.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

image
image
image
image

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner August 5, 2022 10:15
@vinit-chauhan vinit-chauhan added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:tenable_sc Tenable Security Center labels Aug 5, 2022
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-16T06:37:41.559+0000

  • Duration: 17 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 5, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 2.879
Classes 100.0% (3/3) 💚 2.879
Methods 100.0% (41/41) 💚 9.942
Lines 96.852% (923/953) 👍 5.025
Conditionals 100.0% (0/0) 💚

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@vinit-chauhan vinit-chauhan changed the title [tenable_sc] Add support for endless pagination [tenable_sc] Fix an indefinite pagination bug by adding explicit pagination termination conditions. Aug 16, 2022
@ShourieG
Copy link
Copy Markdown
Contributor

Some RCA info with regards to the endless pagination would be really good , and was this happening only for the tenable_sc integration or was it in general ?

@vinit-chauhan
Copy link
Copy Markdown
Contributor Author

Hey @ShourieG,
We have analyzed the problem and added our analysis in this issue. And I see a handful of PRs regarding the infinite Pagination, so it seems like an issue in multiple connectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:tenable_sc Tenable Security Center

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tenable_sc] Pagination termination is not happening in Tenable.sc Integration for filebeat version greater than or equal to 8.2.0

4 participants