Skip to content

[cisco_meraki] Update ECS to 8.4.0#3924

Merged
leehinman merged 3 commits intoelastic:mainfrom
leehinman:3864_cisco_meraki_ecs_8.4
Aug 8, 2022
Merged

[cisco_meraki] Update ECS to 8.4.0#3924
leehinman merged 3 commits intoelastic:mainfrom
leehinman:3864_cisco_meraki_ecs_8.4

Conversation

@leehinman
Copy link
Contributor

@leehinman leehinman commented Aug 1, 2022 •
edited
Loading

Update cisco_meraki to ECS 8.4.0

Closes #3864

@leehinman leehinman changed the title Update ECS to 8.4.0 [cisco_meraki] Update ECS to 8.4.0 Aug 1, 2022
@elasticmachine
Copy link

elasticmachine commented Aug 1, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T18:52:44.732+0000

  • Duration: 19 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 1, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚 2.863
Classes 100.0% (9/9) 💚 2.863
Methods 100.0% (64/64) 💚 10.738
Lines 99.289% (1117/1125) 👍 8.648
Conditionals 100.0% (0/0) 💚

@leehinman leehinman marked this pull request as ready for review August 1, 2022 18:59
@leehinman leehinman requested a review from a team as a code owner August 1, 2022 18:59
@elasticmachine
Copy link

elasticmachine commented Aug 1, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 reviewed Aug 1, 2022
View reviewed changes
packages/cisco_meraki/docs/README.md Outdated
Copy link
Contributor

@efd6 efd6 Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Contributor Author

@leehinman leehinman Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it wasn't. Nice catch. removed from fields & rebuilt

@leehinman leehinman force-pushed the 3864_cisco_meraki_ecs_8.4 branch from e268558 to 893c994 Compare August 8, 2022 17:08
@leehinman leehinman force-pushed the 3864_cisco_meraki_ecs_8.4 branch from 893c994 to a8fd284 Compare August 8, 2022 18:52
taylor-swanson
taylor-swanson approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehinman leehinman merged commit b632e9b into elastic:main Aug 8, 2022
@leehinman leehinman deleted the 3864_cisco_meraki_ecs_8.4 branch August 8, 2022 21:02
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 left review comments

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Integration:cisco_meraki Cisco Meraki

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cisco_meraki] ECS 8.4.0 expected values incompatibility for threat.software.type

5 participants

@leehinman @elasticmachine @efd6 @taylor-swanson @andrewkroh