Skip to content

[sentinel_one] Update ECS to 8.4.0#3910

Merged
leehinman merged 2 commits intoelastic:mainfrom
leehinman:3887_sentinel_one_network_direction
Aug 8, 2022
Merged

[sentinel_one] Update ECS to 8.4.0#3910
leehinman merged 2 commits intoelastic:mainfrom
leehinman:3887_sentinel_one_network_direction

Conversation

@leehinman
Copy link
Contributor

@leehinman leehinman commented Jul 30, 2022

Update sentinel_one to ECS 8.4.0

Closes #3887

@elasticmachine
Copy link

elasticmachine commented Jul 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T17:10:49.267+0000

  • Duration: 18 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@leehinman leehinman changed the title Update ECS to 8.4.0 [sentinel_one] Update ECS to 8.4.0 Jul 30, 2022
@leehinman leehinman force-pushed the 3887_sentinel_one_network_direction branch 2 times, most recently from 8e9c57c to 84a5f68 Compare July 30, 2022 22:42
@elasticmachine
Copy link

elasticmachine commented Jul 30, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.863
Classes 100.0% (5/5) 💚 2.863
Methods 100.0% (70/70) 💚 10.738
Lines 98.157% (2556/2604) 👍 7.516
Conditionals 100.0% (0/0) 💚

@leehinman leehinman marked this pull request as ready for review August 1, 2022 13:42
@leehinman leehinman requested a review from a team as a code owner August 1, 2022 13:42
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think it's worthwhile to change string to one of the allowed values, so this feature is tested? I suppose it already is tested, though, since we exclude the value as it's not allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:sentinel_one SentinelOne

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sentinel_one] ECS 8.4.0 network.direction expected value mismatch

4 participants