[Snort] Add Snort 3 JSON alert file compatibility#3876
Merged
andrewkroh merged 8 commits intoelastic:mainfrom Aug 15, 2022
Merged
[Snort] Add Snort 3 JSON alert file compatibility#3876andrewkroh merged 8 commits intoelastic:mainfrom
andrewkroh merged 8 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
efd6
reviewed
Jul 28, 2022
packages/snort/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/snort/data_stream/log/elasticsearch/ingest_pipeline/plaintext.yml
Outdated
Show resolved
Hide resolved
packages/snort/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Contributor
|
/test |
legoguy1000
commented
Jul 28, 2022
packages/snort/data_stream/log/_dev/test/pipeline/test-log-json.log-expected.json
Outdated
Show resolved
Hide resolved
🌐 Coverage report
|
legoguy1000
changed the title
Contributor
|
/test |
1 similar comment
Contributor
|
/test |
Contributor
|
/test |
efd6
reviewed
Aug 3, 2022
Contributor
efd6
left a comment
efd6
left a comment
There was a problem hiding this comment.
It looks like unfortunately snort.gid needs to be reverted to a long.
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Member
|
/test |
andrewkroh
approved these changes
Aug 15, 2022
Contributor
Author
|
looks good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for the new Snort 3 JSON file for alerts
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots