[Fortinet] Deprecate original integration & change logfile to filestream#3819
Merged
andrewkroh merged 2 commits intoelastic:mainfrom Aug 16, 2022
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
efd6
reviewed
Jul 25, 2022
packages/fortinet_forticlient/data_stream/log/agent/stream/filestream.yml.hbs
Outdated
Show resolved
Hide resolved
packages/fortinet_forticlient/data_stream/log/agent/stream/filestream.yml.hbs
Outdated
Show resolved
Hide resolved
Contributor
|
/test |
🌐 Coverage report
|
Contributor
Author
|
@efd6 comments resolved. |
Contributor
|
/test |
efd6
approved these changes
Jul 27, 2022
legoguy1000
force-pushed
the
fortinet-filestream-input
branch
from
7107817 to
67985c0
Compare
Contributor
|
/test |
1 similar comment
Contributor
|
/test |
andrewkroh
added
Team:Security-External Integrations
Integration:Fortinet
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
requested changes
Aug 15, 2022
Member
andrewkroh
left a comment
andrewkroh
left a comment
There was a problem hiding this comment.
I think changing from log to filestream will cause problems for users because they will lose their existing state. Much of this is discussed in #2518. I think we should hold off on this change given the packages are GA. We'll cover making the change with #2518.
So I think the filestream changes should be reverted.
Contributor
Author
|
@andrewkroh Will do. |
legoguy1000
force-pushed
the
fortinet-filestream-input
branch
from
82e087d to
ad51d5f
Compare
legoguy1000
force-pushed
the
fortinet-filestream-input
branch
from
ad51d5f to
994c676
Compare
andrewkroh
reviewed
Aug 15, 2022
andrewkroh
approved these changes
Aug 15, 2022
Contributor
Author
|
GTG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots