[sentinel_one] Change event.kind and adjust some relevant alert fields#3669
Merged
andrewkroh merged 9 commits intoelastic:mainfrom Aug 16, 2022
ChriZzn:main
Merged
[sentinel_one] Change event.kind and adjust some relevant alert fields#3669andrewkroh merged 9 commits intoelastic:mainfrom ChriZzn:main
andrewkroh merged 9 commits intoelastic:mainfrom
ChriZzn:main
Conversation
|
💚 CLA has been signed |
Member
|
Hi @ChriZzn, could you please sign the CLA https://www.elastic.co/contributor-agreement? Thanks. |
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
requested changes
Jul 20, 2022
packages/sentinel_one/data_stream/threat/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/sentinel_one/data_stream/threat/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
| - set: | ||
| field: process.name | ||
| copy_from: json.threatInfo.originatorProcess | ||
| if: ctx.json.threatInfo.originatorProcess != null |
Member
There was a problem hiding this comment.
Instead of the if you can use ignore_empty_value: true.
adjusting based on PR
ChriZzn
commented
Jul 21, 2022
Contributor
Author
ChriZzn
left a comment
There was a problem hiding this comment.
Hi Andrew,
thanks for the input, i have adjusted all problems/recommendations, should suit so far.
Regards Christoph
Member
|
/test |
andrewkroh
approved these changes
Aug 16, 2022
🌐 Coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added relevant fields for Alerts and changed the event.kind field to "alert", this is useful to show the Threats from Sentinel One in Kibana under "External Alerts"
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots