Skip to content

[cef] Format {source,destination}.mac per ECS#3566

Merged
andrewkroh merged 2 commits intoelastic:mainfrom
andrewkroh:cef/format-macs
Jun 23, 2022
Merged

[cef] Format {source,destination}.mac per ECS#3566
andrewkroh merged 2 commits intoelastic:mainfrom
andrewkroh:cef/format-macs

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jun 22, 2022

What does this PR do?

Format the {source,destination}.mac field as per ECS.

The notation format from RFC 7042 is suggested: Each octet (that is, 8-bit byte) is represented by two uppercase hexadecimal digits giving the value of the octet as an unsigned integer. Successive octets are separated by a hyphen.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Format the `{source,destination}.mac` field as per ECS.

> The notation format from RFC 7042 is suggested: Each octet (that is, 8-bit byte) is represented by two [uppercase] hexadecimal digits giving the value of the octet as an unsigned integer. Successive octets are separated by a hyphen.
[git-generate]
cd packages/cef
elastic-package-changelog add-next --pr 3566 --type bugfix --description "Format source.mac and destination.mac as per ECS."
@andrewkroh andrewkroh marked this pull request as ready for review June 22, 2022 20:34
@andrewkroh andrewkroh requested a review from a team as a code owner June 22, 2022 20:34
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-22T20:34:51.242+0000

  • Duration: 15 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 89
Skipped 0
Total 89

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.432
Classes 100.0% (3/3) 💚 3.432
Methods 95.455% (21/22) 👍 6.546
Lines 89.831% (424/472) 👎 -0.116
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh merged commit 65f123b into elastic:main Jun 23, 2022
andrewkroh added a commit that referenced this pull request Jun 28, 2022
This updates the ECS version used in all non-deprecated packages owned by elastic/security-external-integrations.

These packages required fixes in order to comply with the `pattern` added to ECS to validate MAC addresses.

- cef - #3566
- crowdstrike - #3302
- cylance.protect - #3368
- fortinet.fortimanager - #3401
- iptables.log - #3358
- microsoft_dhcp - #3300
- pfsense - #3303
- snort - #3301
- sonicwall.firewall - #3360
- sophos.utm - #3370

NOTE: The following packages were not updated for 8.2.0. I didn't catch anything in 8.1 or 8.2 that needed changed.

 - auth0 - 1.12.0
 - carbon_black_cloud - 8.0.0
 - cisco_ise - 8.0.0
 - cisco_meraki - 8.0.0
 - hid_bravura_monitor - 1.12.0
 - modsecurity - 1.12.0
 - mysql_enterprise - 8.0.0
 - netskope - 8.0.0
 - oracle - 8.0.0
 - symantec_endpoint - 1.12.0
 - ti_recordedfuture - 8.0

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@6efa1ecb3871 \
  --ecs-version=8.3.0 \
  -ecs-git-ref=v8.3.0 \
  --pr=3353 \
  --owner=elastic/security-external-integrations \
  packages/*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:cef Common Event Format (CEF)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants