Skip to content

update 1Password readme#3534

Merged
ellis-elastic merged 8 commits intoelastic:mainfrom
ellis-elastic:1Password-docs
Jul 5, 2022
Merged

update 1Password readme#3534
ellis-elastic merged 8 commits intoelastic:mainfrom
ellis-elastic:1Password-docs

Conversation

@ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Jun 20, 2022

Type of change

  • Enhancement

What does this PR do?

improved the clarity of the English

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

improved the clarity of the English
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Team:Security-External Integrations Integration:1password 1Password (Partner supported) labels Jun 20, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner June 20, 2022 09:30
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-04T11:13:12.728+0000

  • Duration: 15 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

ellis-elastic and others added 3 commits June 21, 2022 14:57
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
@adriansr
Copy link
Contributor

adriansr commented Jun 23, 2022

Hi @ellis-elastic ,

The build is failing because the _dev/build/docs/README.md and docs/README.md files contain conflicting changes.

The correct way of modifying the README is to change _dev/build/docs/README.md only, and then run elastic-package build so that the file under docs/README.md is updated with changes to the former.

I can do that for you, but I don't know which changes you want to keep, the ones under _dev or the ones under doc.

@ellis-elastic
Copy link
Contributor Author

I've run build again

ellis-elastic and others added 2 commits June 24, 2022 08:53
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@bmorelli25
Copy link
Member

[2022-06-29T08:35:29.315Z] README.md is outdated. Rebuild the package with 'elastic-package build'

Ran build
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 4.059
Classes 100.0% (2/2) 💚 4.059
Methods 90.909% (20/22) 👍 3.053
Lines 92.793% (206/222) 👍 5.3
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:1password 1Password (Partner supported)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants