Skip to content

[httpjson] Remove conditional rendering based on oauth_id of auth options#3518

Merged
marc-gr merged 3 commits intoelastic:mainfrom
marc-gr:fix-httpjson-auth
Jun 20, 2022
Merged

[httpjson] Remove conditional rendering based on oauth_id of auth options#3518
marc-gr merged 3 commits intoelastic:mainfrom
marc-gr:fix-httpjson-auth

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 16, 2022

What does this PR do?

Auth options were supedited to the existence of oauth_id, which made valid configs not rendered. Removing this will delegate the validation of the config to the input itself.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:httpjson Custom API labels Jun 16, 2022
@marc-gr marc-gr requested a review from a team as a code owner June 16, 2022 12:55
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-16T13:43:25.892+0000

  • Duration: 17 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 16, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.432
Classes 100.0% (0/0) 💚 3.432
Methods 100.0% (3/3) 💚 11.091
Lines 100.0% (0/0) 💚 10.055
Conditionals 100.0% (0/0) 💚

@marc-gr marc-gr merged commit 48053fc into elastic:main Jun 20, 2022
@marc-gr marc-gr deleted the fix-httpjson-auth branch June 20, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:httpjson Custom API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants