Skip to content

[PFsense] Update PFsense HAProxy parsing#3504

Merged
efd6 merged 4 commits intoelastic:mainfrom
legoguy1000:3501-pfsense-haproxy-updates
Jun 15, 2022
Merged

[PFsense] Update PFsense HAProxy parsing#3504
efd6 merged 4 commits intoelastic:mainfrom
legoguy1000:3501-pfsense-haproxy-updates

Conversation

@legoguy1000
Copy link
Contributor

What does this PR do?

Add support for parsing HTTP, TCP and Error logs for HAproxy running on PFsense.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 marked this pull request as ready for review June 14, 2022 02:23
@legoguy1000 legoguy1000 requested a review from a team as a code owner June 14, 2022 02:23
@elasticmachine
Copy link

elasticmachine commented Jun 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-15T00:37:40.411+0000

  • Duration: 17 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 14, 2022

/test

@elasticmachine
Copy link

elasticmachine commented Jun 14, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 88.889% (8/9) 👎 -7.679
Classes 88.889% (8/9) 👎 -7.679
Methods 92.063% (58/63) 👍 3.256
Lines 89.35% (646/723) 👎 -0.546
Conditionals 100.0% (0/0) 💚

@legoguy1000
Copy link
Contributor Author

@efd6 ready to retest

@efd6
Copy link
Contributor

efd6 commented Jun 15, 2022

/test

@legoguy1000
Copy link
Contributor Author

fixed

@efd6
Copy link
Contributor

efd6 commented Jun 15, 2022

/test

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@efd6 efd6 merged commit f3ce562 into elastic:main Jun 15, 2022
@legoguy1000 legoguy1000 deleted the 3501-pfsense-haproxy-updates branch June 15, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Pfsense Integration]

3 participants