Skip to content

cyberarkpas: Make paths a multi string var#3497

Merged
adriansr merged 1 commit intoelastic:mainfrom
adriansr:fix_cyberarkpas_paths
Jun 9, 2022
Merged

cyberarkpas: Make paths a multi string var#3497
adriansr merged 1 commit intoelastic:mainfrom
adriansr:fix_cyberarkpas_paths

Conversation

@adriansr
Copy link
Contributor

@adriansr adriansr commented Jun 9, 2022

What does this PR do?

The definition for the paths variable was missing the multi flag, preventing it to be used when setting up the integration in the UI, as it would never be an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@adriansr adriansr added bug Something isn't working, use only for issues Team:Security-External Integrations labels Jun 9, 2022
The definition for the paths variable was missing the `multi` flag,
preventing it to be used when setting up the integration in the UI.
@adriansr adriansr marked this pull request as ready for review June 9, 2022 10:41
@adriansr adriansr requested a review from a team as a code owner June 9, 2022 10:41
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-09T10:40:56.021+0000

  • Duration: 64 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 87
Skipped 0
Total 87

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.432
Classes 100.0% (1/1) 💚 3.432
Methods 100.0% (17/17) 💚 11.111
Lines 92.441% (856/926) 👍 2.683
Conditionals 100.0% (0/0) 💚

@adriansr adriansr merged commit c7c766a into elastic:main Jun 9, 2022
@adriansr adriansr deleted the fix_cyberarkpas_paths branch June 9, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants