Skip to content

[Sonicwall_firewall] Fix handling of NAT fields#3420

Merged
adriansr merged 2 commits intoelastic:mainfrom
adriansr:sonicwall_fix
May 26, 2022
Merged

[Sonicwall_firewall] Fix handling of NAT fields#3420
adriansr merged 2 commits intoelastic:mainfrom
adriansr:sonicwall_fix

Conversation

@adriansr
Copy link
Contributor

@adriansr adriansr commented May 24, 2022

What does this PR do?

Fixes the logic for handling the different formats for NAT fields in the recently added sonicwall_firewall package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@adriansr adriansr added the bug Something isn't working, use only for issues label May 24, 2022
@adriansr adriansr requested a review from a team as a code owner May 24, 2022 15:48
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 24, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-25T18:35:44.530+0000

  • Duration: 15 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 24, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.538
Classes 100.0% (1/1) 💚 3.538
Methods 100.0% (16/16) 💚 11.542
Lines 98.211% (1098/1118) 👍 8.895
Conditionals 100.0% (0/0) 💚

@adriansr
Copy link
Contributor Author

/test

@adriansr
Copy link
Contributor Author

Waiting for #3426 to be merged so that the use of a second IPv6 address is allowed by elastic-package.

@adriansr
Copy link
Contributor Author

/test

@adriansr adriansr merged commit b7854b0 into elastic:main May 26, 2022
@adriansr adriansr deleted the sonicwall_fix branch May 26, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:sonicwall_firewall SonicWall Firewall

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants