okta: fill okta.request.ip_chain.* as a flattened object#3326
Merged
efd6 merged 2 commits intoelastic:mainfrom May 16, 2022
Merged
okta: fill okta.request.ip_chain.* as a flattened object#3326efd6 merged 2 commits intoelastic:mainfrom
efd6 merged 2 commits intoelastic:mainfrom
Conversation
efd6
added
enhancement
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
commented
May 11, 2022
efd6
added
bug
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
r00tu53r
reviewed
May 12, 2022
Comment on lines
+341
to
+342
| field: _ingest._value.geographicalContext | ||
| target_field: _ingest._value.geographical_context |
Contributor
There was a problem hiding this comment.
Are renaming fields breaking changes ? Could it break custom dashboards / searches ?
Contributor
Author
There was a problem hiding this comment.
It would be if the data had got into documents previously, but because of the old parsing these have not previously been available.
r00tu53r
approved these changes
May 16, 2022
andrewkroh
approved these changes
May 16, 2022
This was referenced May 22, 2022
Merged
6 tasks
efd6
added a commit
to efd6/beats
that referenced
this pull request
Feb 21, 2023
…ned object Added to reflect addition in okta integration: elastic/integrations#3326
efd6
added a commit
to elastic/beats
that referenced
this pull request
Feb 22, 2023
…ned object (#34621) Added to reflect addition in okta integration: elastic/integrations#3326
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Feb 23, 2023
…ned object (#34621) Added to reflect addition in okta integration: elastic/integrations#3326 (cherry picked from commit 1f1868d) # Conflicts: # x-pack/filebeat/module/okta/fields.go # x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json
efd6
added a commit
to elastic/beats
that referenced
this pull request
Feb 23, 2023
….ip_chain.* as a flattened object (#34657) * x-pack/filebeat/module/okta: fill okta.request.ip_chain.* as a flattened object (#34621) Added to reflect addition in okta integration: elastic/integrations#3326 (cherry picked from commit 1f1868d) # Conflicts: # x-pack/filebeat/module/okta/fields.go # x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json * resolve conflicts --------- Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com> Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
chrisberkhout
pushed a commit
to elastic/beats
that referenced
this pull request
Jun 1, 2023
…ned object (#34621) Added to reflect addition in okta integration: elastic/integrations#3326
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fills the already mapped
okta.request.ip-chainarray, but redefines the mapping as a flattened object array.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots