Skip to content

[panw] Replace syslog input with UDP/TCP input and syslog processor#3323

Merged
taylor-swanson merged 4 commits intoelastic:mainfrom
taylor-swanson:inputs-panw
May 12, 2022
Merged

[panw] Replace syslog input with UDP/TCP input and syslog processor#3323
taylor-swanson merged 4 commits intoelastic:mainfrom
taylor-swanson:inputs-panw

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 10, 2022 •
edited
Loading

What does this PR do?

  • Replace syslog input with UDP and TCP input and syslog processor
  • TCP input supports TLS and custom options
  • Add system tests

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/panw && elastic-package test

Related issues

Screenshots

panw

@taylor-swanson
[panw] Replace syslog input with UDP/TCP input with syslog processor
caa6a63 
- Replace syslog input with UDP and TCP input
- TCP input supports TLS and custom options
- Add system tests
@taylor-swanson taylor-swanson added enhancement New feature or request Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels May 10, 2022
@taylor-swanson taylor-swanson self-assigned this May 10, 2022
@elasticmachine
Copy link

elasticmachine commented May 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:54:54.259+0000

  • Duration: 20 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 10, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (6/6) 💚 3.597
Classes 100.0% (6/6) 💚 3.597
Methods 100.0% (34/34) 💚 11.753
Lines 87.045% (813/934) 👎 -2.068
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review May 10, 2022 19:53
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 10, 2022 19:53
@elasticmachine
Copy link

elasticmachine commented May 10, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@taylor-swanson taylor-swanson merged commit e3dba03 into elastic:main May 12, 2022
@taylor-swanson taylor-swanson deleted the inputs-panw branch May 12, 2022 19:50
This was referenced May 22, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels

enhancement New feature or request Integration:panw Palo Alto Next-Gen Firewall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taylor-swanson @elasticmachine @efd6