Skip to content

[sophos] Improve inputs for Sophos XG#3322

Merged
taylor-swanson merged 4 commits intoelastic:mainfrom
taylor-swanson:inputs-sophos-xg
May 12, 2022
Merged

[sophos] Improve inputs for Sophos XG#3322
taylor-swanson merged 4 commits intoelastic:mainfrom
taylor-swanson:inputs-sophos-xg

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 10, 2022 •
edited
Loading

What does this PR do?

  • Add TLS support to TCP input
  • Add custom TCP options support
  • Add system test for TCP input

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/sophos && elastic-package test

Related issues

Screenshots

sophos_xg

@taylor-swanson
[sophos] Improve inputs for Sophos XG
f03383a 
- Add TLS support to TCP input
- Add custom TCP options support
- Add system test for TCP input
@taylor-swanson taylor-swanson self-assigned this May 10, 2022
@elasticmachine
Copy link

elasticmachine commented May 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:54:55.282+0000

  • Duration: 20 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 10, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (13/13) 💚 3.597
Classes 100.0% (13/13) 💚 3.597
Methods 97.753% (87/89) 👍 9.506
Lines 94.111% (1726/1834) 👍 4.999
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review May 10, 2022 16:48
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 10, 2022 16:48
@elasticmachine
Copy link

elasticmachine commented May 10, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you add tests for the TLS case?

@taylor-swanson
Copy link
Contributor Author

taylor-swanson commented May 11, 2022

Will you add tests for the TLS case?

TLS test has been added.

@taylor-swanson taylor-swanson merged commit 98a174f into elastic:main May 12, 2022
@taylor-swanson taylor-swanson deleted the inputs-sophos-xg branch May 12, 2022 19:49
This was referenced May 22, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels

enhancement New feature or request Integration:sophos Sophos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taylor-swanson @elasticmachine @efd6