[juniper_srx] Improve TCP input#3320
Merged
taylor-swanson merged 4 commits intoelastic:mainfrom May 12, 2022
taylor-swanson:inputs-juniper-srx
Merged
[juniper_srx] Improve TCP input#3320taylor-swanson merged 4 commits intoelastic:mainfrom taylor-swanson:inputs-juniper-srx
taylor-swanson merged 4 commits intoelastic:mainfrom
taylor-swanson:inputs-juniper-srx
Conversation
- Add TLS support to TCP input - Add custom TCP options support
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
Author
I thought about it originally and was overthinking the complexity of setting that up. I just tested it and it turns out it's trivial to set up and hard code the cert/key pair (we won't test validating certificates). I'll add a TLS test here and to the other packages as well. |
Contributor
Author
|
TLS test has been added. |
efd6
approved these changes
May 11, 2022
This was referenced May 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Screenshots