[cisco_asa] Add TCP input with TLS support#3312
Merged
taylor-swanson merged 6 commits intoelastic:mainfrom May 12, 2022
taylor-swanson:inputs-cisco-asa
Merged
[cisco_asa] Add TCP input with TLS support#3312taylor-swanson merged 6 commits intoelastic:mainfrom taylor-swanson:inputs-cisco-asa
taylor-swanson merged 6 commits intoelastic:mainfrom
taylor-swanson:inputs-cisco-asa
Conversation
- Add TCP input, with TLS and custom options support - Add system test for TCP input
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
r00tu53r
approved these changes
May 11, 2022
Contributor
Author
Fair point. I haven't heard of any complaints about ports yet. That may be a good idea going forward, but maybe that'd best be handled in a separate issue with greater coordination between packages (and potentially teams). |
Contributor
|
LGTM! |
This was referenced May 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Screenshots