Skip to content

[windows] Drop unset fields in sysmon_operational data stream#3283

Merged
adriansr merged 5 commits intoelastic:mainfrom
adriansr:win_sysmon_dash_fields
May 9, 2022
Merged

[windows] Drop unset fields in sysmon_operational data stream#3283
adriansr merged 5 commits intoelastic:mainfrom
adriansr:win_sysmon_dash_fields

Conversation

@adriansr
Copy link
Contributor

@adriansr adriansr commented May 5, 2022

What does this PR do?

This PR updates the windows package so that EventData fields whose value is - are dropped before being processed.

This value is a placeholder for an unset field and should be ignored.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@adriansr adriansr added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:windows Windows labels May 5, 2022
@adriansr adriansr requested a review from a team as a code owner May 5, 2022 13:50
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-06T06:55:31.812+0000

  • Duration: 17 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 5, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -8.824
Classes 87.5% (7/8) 👎 -8.824
Methods 84.884% (73/86) 👎 -3.882
Lines 93.376% (4962/5314) 👍 3.405
Conditionals 100.0% (0/0) 💚

},
"name": "cmd.exe",
"parent": {
"entity_id": "{00000000-0000-0000-0000-000000000000}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to drop zero UUIDs as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@adriansr adriansr requested a review from a team May 6, 2022 06:28
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr added the Team:Integrations Label for the Integrations team label May 9, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:windows Windows Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants