Skip to content

Update tenable.sc readme#3165

Merged
bmorelli25 merged 8 commits intoelastic:mainfrom
ellis-elastic:tenable-sc-docs
Jun 24, 2022
Merged

Update tenable.sc readme#3165
bmorelli25 merged 8 commits intoelastic:mainfrom
ellis-elastic:tenable-sc-docs

Conversation

@ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 21, 2022 •
edited
Loading

added links to tenable documentation and made the English clearer.

Type of change

  • Enhancement

What does this PR do?

added links to tenable documentation and made the English clearer.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
Update tenable.sc readme
cf01953 
added links to tenable documentation and made the English clearer.
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Apr 21, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 21, 2022 14:21
@ellis-elastic ellis-elastic marked this pull request as draft April 21, 2022 14:21
@elasticmachine
Copy link

elasticmachine commented Apr 21, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-24T07:52:53.698+0000

  • Duration: 16 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ellis-elastic ellis-elastic marked this pull request as ready for review April 22, 2022 08:19
bmorelli25
bmorelli25 requested changes Apr 27, 2022
View reviewed changes
@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.546
Classes 100.0% (3/3) 💚 3.546
Methods 100.0% (41/41) 💚 10.778
Lines 96.852% (923/953) 👍 5.991
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

elasticmachine commented Jun 7, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

r00tu53r
r00tu53r reviewed Jun 9, 2022
View reviewed changes
@ellis-elastic
update readme
701a90c 
fixed missing link and HTML
@ellis-elastic
reran build
6e11c7d 
 reran build
@ellis-elastic
update readme
514fb07 
Pointed users to Teanable's content.. In case the steps change the user would always have up-to-date information.
r00tu53r
r00tu53r approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@bmorelli25 bmorelli25 merged commit 69b3dd5 into elastic:main Jun 24, 2022
@andrewkroh andrewkroh mentioned this pull request Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

+1 more reviewer

@r00tu53r r00tu53r r00tu53r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ellis-elastic @elasticmachine @bmorelli25 @r00tu53r @epixa