Skip to content

update pfSense documentation#3145

Merged
bmorelli25 merged 5 commits intoelastic:mainfrom
ellis-elastic:pfsense
Jun 20, 2022
Merged

update pfSense documentation#3145
bmorelli25 merged 5 commits intoelastic:mainfrom
ellis-elastic:pfsense

Conversation

@ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 20, 2022 •
edited
Loading

updated links in the documentation to the vendor documentation.

Type of change

  • Enhancement

What does this PR do?

updated links in the documentation to the vendor documentation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
update pfSense documentation
f763418 
updated links in the documentation to the vendor documentation.
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Apr 20, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 20, 2022 16:30
@ellis-elastic ellis-elastic marked this pull request as draft April 20, 2022 16:30
@elasticmachine
Copy link

elasticmachine commented Apr 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-20T08:36:29.096+0000

  • Duration: 19 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ellis-elastic ellis-elastic marked this pull request as ready for review April 21, 2022 07:01
bmorelli25
bmorelli25 reviewed Apr 27, 2022
View reviewed changes
bmorelli25
bmorelli25 requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change on the note.

@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 88.889% (8/9) 👎 -7.615
Classes 88.889% (8/9) 👎 -7.615
Methods 92.063% (58/63) 👍 2.591
Lines 89.35% (646/723) 👎 -1.621
Conditionals 100.0% (0/0) 💚

@ellis-elastic
Update readme
098f969 
removed HTML note code
@elasticmachine
Copy link

elasticmachine commented Jun 7, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

r00tu53r
r00tu53r approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25 bmorelli25 merged commit e800407 into elastic:main Jun 20, 2022
@andrewkroh andrewkroh mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

+1 more reviewer

@r00tu53r r00tu53r r00tu53r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ellis-elastic @elasticmachine @bmorelli25 @r00tu53r @epixa