Skip to content

Update Jupiter JUNOS readme#3133

Merged
ellis-elastic merged 6 commits intoelastic:mainfrom
ellis-elastic:juniper-junos-docs
Jun 10, 2022
Merged

Update Jupiter JUNOS readme#3133
ellis-elastic merged 6 commits intoelastic:mainfrom
ellis-elastic:juniper-junos-docs

Conversation

@ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 20, 2022 •
edited
Loading

added link to Jupiter Junos documentation

Type of change

  • Enhancement
    added link to Jupiter Junos documentation

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
update readme
15f7a4f 
added link to Jupiter Junos documentation
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Apr 20, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 20, 2022 11:46
@elasticmachine
Copy link

elasticmachine commented Apr 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-09T13:42:37.795+0000

  • Duration: 27 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ellis-elastic ellis-elastic marked this pull request as draft April 20, 2022 11:58
@ellis-elastic ellis-elastic marked this pull request as ready for review April 21, 2022 07:03
@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.313
Classes 100.0% (1/1) 💚 3.313
Methods 77.778% (7/9) 👎 -10.911
Lines 82.143% (46/56) 👎 -6.662
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

elasticmachine commented Jun 7, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

r00tu53r
r00tu53r reviewed Jun 9, 2022
View reviewed changes
r00tu53r
r00tu53r approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@ellis-elastic ellis-elastic merged commit 29dc7bf into elastic:main Jun 10, 2022
@ellis-elastic ellis-elastic deleted the juniper-junos-docs branch June 10, 2022 09:34
@andrewkroh andrewkroh mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

+1 more reviewer

@r00tu53r r00tu53r r00tu53r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ellis-elastic @elasticmachine @bmorelli25 @r00tu53r @epixa