[Multiple Packages] adding change to forwarded tag template to multiple packages#3092
Merged
P1llus merged 2 commits intoelastic:mainfrom Apr 13, 2022
Merged
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Member
Author
|
Added a fix for timestamp field mapping as well for the github package to get the CI to pass, they are usually added to base-fields.yml rather than ecs.yml for now. |
Member
It doesn't affect |
andrewkroh
approved these changes
Apr 13, 2022
| @@ -1,5 +1,3 @@ | |||
| - name: "@timestamp" | |||
Member
There was a problem hiding this comment.
This would be preferred, but it's not supported because of elastic/elastic-package#749.
kaiyan-sheng
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The format used to check if
publisher_pipeline.disable_host: trueshould be used is incorrectChecklist
changelog.ymlfile.