Skip to content

Update Atlassian Jira Readme#3063

Merged
ellis-elastic merged 10 commits intoelastic:mainfrom
ellis-elastic:Atlassian-jira-docs
Apr 14, 2022
Merged

Update Atlassian Jira Readme#3063
ellis-elastic merged 10 commits intoelastic:mainfrom
ellis-elastic:Atlassian-jira-docs

Conversation

@ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 11, 2022

Added link to Atlassian documentation

Type of change

  • Enhancement

What does this PR do?

Added link to Atlassian documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Added link to Atlassian documentation
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 11, 2022 15:40
@elasticmachine
Copy link

elasticmachine commented Apr 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-13T14:32:03.788+0000

  • Duration: 13 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Apr 12, 2022

/test

@r00tu53r r00tu53r added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:atlassian_jira Atlassian Jira (Community supported) Team:Security-External Integrations labels Apr 12, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletions indicated in docs/README.md for field docs (host.os.name.text ..... user.target.name.text) shouldn't be here.

I think its because the updated docs/README.md has not been committed/pushed. Please apply these steps for all the open PRs.

  • Change readme under _dev/build/docs/README.md (if it exists)
  • Run elastic-package build
  • Commit _dev/build/docs/README.md and docs/README.md
  • Push changes

Fixed typo
@ellis-elastic
Copy link
Contributor Author

@r00tu53r r00tu53r I did run build on the files.

Added a space so I can re run build
@ellis-elastic
Copy link
Contributor Author

I've added a space to the readme file so I could re run build

@r00tu53r
Copy link
Contributor

/test

@r00tu53r
Copy link
Contributor

I've added a space to the readme file so I could re run build

@ellis-elastic there is no need to add space or make a spurious change to trigger the build. I suspect that your elastic-package version is old or the cache (under ~/.elastic-package) is not ok. I've pushed the changes to this one to fix the problem.

You could try this on the next/other PR -

  • Remove the cache
    rm -rf ~/.elastic-package

  • Rebuild
    elastic-package build

@r00tu53r
Copy link
Contributor

/test

1 similar comment
@r00tu53r
Copy link
Contributor

/test

@ellis-elastic
Copy link
Contributor Author

I've installed v0.46.1 and rerun build

@v1v
Copy link
Member

v1v commented Apr 13, 2022

/test

1 similar comment
@v1v
Copy link
Member

v1v commented Apr 13, 2022

/test

Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:atlassian_jira Atlassian Jira (Community supported)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants