Skip to content

Update Microsoft SQL Server readme#3058

Merged
ollyhowell merged 4 commits intoelastic:mainfrom
ellis-elastic:Microsoft-SQL-Server-docs
Apr 13, 2022
Merged

Update Microsoft SQL Server readme#3058
ollyhowell merged 4 commits intoelastic:mainfrom
ellis-elastic:Microsoft-SQL-Server-docs

Conversation

@ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 11, 2022

Added links to Microsoft documentation

Type of change

  • Enhancement

What does this PR do?

Added links to Microsoft documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Added links to Microsoft documentation
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 11, 2022 14:26
@elasticmachine
Copy link

elasticmachine commented Apr 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-13T01:22:04.982+0000

  • Duration: 12 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Apr 12, 2022

/test

@r00tu53r r00tu53r added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:Security-External Integrations Integration:microsoft_sqlserver Microsoft SQL Server labels Apr 12, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

ellis-elastic and others added 2 commits April 12, 2022 10:54
Removed two blank lines and ran build
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ellis-elastic thank you for the contribution. You can merge after the CI passes.

I noticed the CI was failing as the generated README.md (the one under docs/README.md) was not committed/pushed. So I pushed that.

@ollyhowell ollyhowell merged commit eb9a314 into elastic:main Apr 13, 2022
@ellis-elastic ellis-elastic deleted the Microsoft-SQL-Server-docs branch April 25, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:microsoft_sqlserver Microsoft SQL Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants