Merged
Conversation
r00tu53r
added
bug
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
efd6
reviewed
Mar 30, 2022
| ICMP TTL:64 TOS:0x0 ID:6922 IpLen:20 DgmLen:84 DF | ||
| Type:8 Code:0 ID:101 Seq:1 ECHO No newline at end of file | ||
| Type:8 Code:0 ID:101 Seq:1 ECHO | ||
|
|
Contributor
There was a problem hiding this comment.
Does this need to be two newlines?
Contributor
Author
There was a problem hiding this comment.
Not required. The defined pattern is ^\[\*\*\]. So this works too.
[**] [1:1000004:0] Pinging... [**]
[Classification: Attempted Information Leak] [Priority: 2]
09/04-21:53:15.299988 10.100.10.190 -> 175.16.199.1
ICMP TTL:64 TOS:0x0 ID:6922 IpLen:20 DgmLen:84 DF
Type:8 Code:0 ID:101 Seq:1 ECHO
[**] [1:1000005:0] Pinging... [**]
[Classification: Attempted Information Leak] [Priority: 3]
09/04-21:53:15.299988 10.200.11.90 -> 17.16.99.11
ICMP TTL:64 TOS:0x0 ID:6922 IpLen:20 DgmLen:84 DF
Type:8 Code:0 ID:101 Seq:1 ECHO
Contributor
Author
|
/test |
efd6
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR appends a newline character to the last line of the log. Without this filebeat didn't send the entire multiline block which broke the pipeline and hence the failing system tests reported in CI.
Checklist
changelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.How to test this PR locally
elastic-package test system -vRelated issues